<html>
<head><meta charset="utf-8"><title>Thanks gets confused by subtrees · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html">Thanks gets confused by subtrees</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="238988375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988375">(May 16 2021 at 15:59)</a>:</h4>
<p><a href="/user_uploads/4715/pcnrAmobv0IUifIN5EneMAV5/Screenshot_20210516-105820_Firefox.jpg">Screenshot_20210516-105820_Firefox.jpg</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/pcnrAmobv0IUifIN5EneMAV5/Screenshot_20210516-105820_Firefox.jpg" title="Screenshot_20210516-105820_Firefox.jpg"><img src="/user_uploads/4715/pcnrAmobv0IUifIN5EneMAV5/Screenshot_20210516-105820_Firefox.jpg"></a></div>



<a name="238988514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988514">(May 16 2021 at 16:01)</a>:</h4>
<p>It .. shouldn't? I don't know how to interpret your screenshot... feel free to file an issue on rust-lang/thanks, though.</p>



<a name="238988524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988524">(May 16 2021 at 16:01)</a>:</h4>
<p>(deleted)</p>



<a name="238988592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988592">(May 16 2021 at 16:02)</a>:</h4>
<p>Sorry, zulip is glitching and didn't send my text</p>



<a name="238988601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988601">(May 16 2021 at 16:02)</a>:</h4>
<p>This isn't <em>really</em> a bug, I just thought it was funny thanks shows <span class="user-mention silent" data-user-id="256841">Nick Cameron</span> with 5x as many commits as bors in 1.54</p>



<a name="238988682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988682">(May 16 2021 at 16:03)</a>:</h4>
<p>oh, well, that's expected -- it'll happen in any non-bors managed project getting merged in. To my knowledge, though, we should treat subtrees and submodules completely identically unless something went wrong in the input (we deduplicate by commit hash, and IIRC the imported commits during subtree merge have the same commit hash in the "parent" repostiory and the one being imported)</p>



<a name="238988751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988751">(May 16 2021 at 16:04)</a>:</h4>
<p>Hmm maybe thanks is ignoring submodule commits then? 973 commits in 3 weeks definitely does not sound reasonable</p>



<a name="238988757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238988757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238988757">(May 16 2021 at 16:04)</a>:</h4>
<p>Aghhh I hate zulip so much</p>



<a name="238989338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238989338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238989338">(May 16 2021 at 16:13)</a>:</h4>
<p><span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span> ultimately it's not a high priority at all to investigate for me, though likely would be interesting. Maybe the import got messed up, maybe something else went wrong, I don't know</p>



<a name="238990253"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238990253" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238990253">(May 16 2021 at 16:27)</a>:</h4>
<p>If it got fixed, would the old blog posts get updated? Or are they part of the release and frozen in time?</p>



<a name="238990356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Thanks%20gets%20confused%20by%20subtrees/near/238990356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Thanks.20gets.20confused.20by.20subtrees.html#238990356">(May 16 2021 at 16:28)</a>:</h4>
<p>thanks is entirely independent from the release schedule and we regenerate the whole site each time</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>